Opened 13 years ago

Closed 13 years ago

#444 closed request (fixed)

iterators in lookups

Reported by: Peter Owned by: Peter
Priority: major Milestone: yat 0.5
Component: classifier Version: trunk
Keywords: Cc:

Description

go through how iterators are defined in lookups.

Two issues:

  1. standard requires that value_type is not const
  2. Weighted iterators should use DataWeight rather than std::pair<double, double>

Change History (8)

comment:1 Changed 13 years ago by Peter

(In [1525]) refs #444 - simplifying code in DataLookupD by calling underlying MatrixLookup? rather than creating iterator yourself.

comment:2 Changed 13 years ago by Peter

(In [1526]) refs #444. same as in [1525] but for DataLookupWeighted1D.

comment:3 Changed 13 years ago by Peter

(In [1528]) refs #444 - started using boost::permutation_iterator for vector iterators from MatrixLookup? and also removed stride layer for const_iterator (stride was always 1).

comment:4 in reply to:  3 Changed 13 years ago by Peter

Replying to peter:

(In [1528]) refs #444 - started using boost::permutation_iterator for vector iterators from MatrixLookup? and also removed stride layer for const_iterator (stride was always 1).

We should do corresponding thing for MatrixLookupWeighted?, but need ticket:396 for that.

comment:5 Changed 13 years ago by Peter

(In [1529]) refs #444 fixing KernelLookup?

comment:6 Changed 13 years ago by Peter

(In [1530]) removing const in value_type - refs #444

comment:7 Changed 13 years ago by Peter

Status: new → assigned

comment:8 Changed 13 years ago by Peter

Resolution: → fixed
Status: assigned → closed

(In [1589]) fixes #444

Note: See TracTickets for help on using tickets.