Opened 15 years ago
Closed 14 years ago
#498 closed discussion (fixed)
mixing weighted and unweighted iterators in normalizers
Reported by: | Peter | Owned by: | Peter |
---|---|---|---|
Priority: | major | Milestone: | yat 0.6 |
Component: | normalizer | Version: | 0.5.1 |
Keywords: | Cc: |
Description
Currently (0.5) the operator()
in range normalizers have an restriction that input and output must either both be weighted or both be unweighted. Is there a good reason for this? For instance, in qQuantileNormalizer, we have:
template<typename RandomAccessIterator1, typename RandomAccessIterator2> void operator()(RandomAccessIterator1 first, RandomAccessIterator1 last, RandomAccessIterator2 result) const;
and the docs says: RandomAccessIterator1
's value type is convertible to RandomAccessIterator2
's value type
I wonder if this is really needed, in other words, the weights are just copied (not modified) so it should be possible to modify the algorithm to allow us to mix weighted and unweighted ranges.
Change History (6)
comment:1 Changed 15 years ago by
Version: | trunk → 0.5.1 |
---|
comment:2 Changed 14 years ago by
Milestone: | yat 0.x+ → yat 0.6 |
---|---|
Status: | new → assigned |
comment:3 Changed 14 years ago by
comment:4 Changed 14 years ago by
comment:5 Changed 14 years ago by
comment:6 Changed 14 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
(In [2155]) Spearman now works with mixed iterators. refs #498