Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#543 closed discussion (fixed)

deprecate MatrixLookup(Matrix, Index, bool) and friends

Reported by: Peter Owned by: Peter
Priority: major Milestone: yat 0.7
Component: classifier Version: trunk
Keywords: Cc:

Description

The following constructors:

MatrixLookup(Matrix data, Index index, bool row_vectors);
MatrixLookup(MatrixLookup data, Index index, bool row_vectors);
MatrixLookupWeighted(MatrixWeighted data, Index index, bool row_vectors);

are IMHO not needed. Instead of calling, for example, MatrixLookup(matrix, index, true) one can call MatrixLookup(matrix, index, Index(m.columns())) or if the true was false one can call MatrixLookup(matrix, Index(m.rows()), index).

One could of course argue that the three constructors are convenient to have, but I think they create not very clear code because it is always confusing what the bool (third argument) implies.

Change History (7)

comment:1 Changed 12 years ago by Peter

Milestone: yat 0.x+yat 0.7

comment:2 Changed 12 years ago by Peter

Resolution: fixed
Status: newclosed

(In [2149]) fixes #543

comment:3 Changed 12 years ago by Peter

Resolution: fixed
Status: closedreopened

incorrect message in [2149]

comment:4 Changed 12 years ago by Peter

Status: reopenednew

comment:5 Changed 12 years ago by Peter

Status: newassigned

comment:6 Changed 12 years ago by Peter

Resolution: fixed
Status: assignedclosed

(In [2223]) fixes #543

comment:7 Changed 11 years ago by Peter

(In [2226]) remove usage of deprecated constructors also in templates and tests. (refs #543)

Note: See TracTickets for help on using tickets.