Opened 11 years ago

Closed 9 years ago

## #689 closed request (fixed)

# replace one_sided_P with lower_P and upper_P

Reported by: | Peter | Owned by: | Peter |
---|---|---|---|

Priority: | major | Milestone: | yat 0.11 |

Component: | statistics | Version: | trunk |

Keywords: | Cc: |

### Description

I find it a bit strange to have functions one-sided P-value. If the want the one-sided p-value they should know whether they want the upper or the lower. Currently, that is decided by the score which implies the one-sided p-value will always be ≤ -0.5 which already there is an indicator that something is strange. I instead propose we implement two functions `lower_p(void)`

and `upper_p(void)`

. These are not necessarily but good thing is that p_value (two-sided) and one-sided can be implemented using these two new functions.

### Change History (9)

### comment:1 Changed 11 years ago by

### comment:2 Changed 10 years ago by

Milestone: | yat 0.x+ → yat 0.11 |
---|

### comment:3 Changed 10 years ago by

Status: | new → assigned |
---|

There are four classes: Fisher, PearsonCorrelation?, ROC, and tTest.

### comment:4 Changed 10 years ago by

### comment:5 Changed 10 years ago by

### comment:6 follow-up: 8 Changed 10 years ago by

(In [3006]) deprecate ROC::p_value, first versions of p_left and p_right (refs #689), but code is terribly duplicated which is better to fix after ticket:754 (refs #754).

### comment:7 Changed 10 years ago by

### comment:8 Changed 9 years ago by

### comment:9 Changed 9 years ago by

Resolution: | → fixed |
---|---|

Status: | assigned → closed |

**Note:**See TracTickets for help on using tickets.

Convention seems to be left-, right-, and two-tailed-P so I suggest p_value, p_left and p_right.