Opened 10 years ago

Closed 8 years ago

#689 closed request (fixed)

replace one_sided_P with lower_P and upper_P

Reported by: Peter Owned by: Peter
Priority: major Milestone: yat 0.11
Component: statistics Version: trunk
Keywords: Cc:

Description

I find it a bit strange to have functions one-sided P-value. If the want the one-sided p-value they should know whether they want the upper or the lower. Currently, that is decided by the score which implies the one-sided p-value will always be ≤ -0.5 which already there is an indicator that something is strange. I instead propose we implement two functions lower_p(void) and upper_p(void). These are not necessarily but good thing is that p_value (two-sided) and one-sided can be implemented using these two new functions.

Change History (9)

comment:1 Changed 10 years ago by Peter

Convention seems to be left-, right-, and two-tailed-P so I suggest p_value, p_left and p_right.

comment:2 Changed 9 years ago by Peter

Milestone: yat 0.x+yat 0.11

comment:3 Changed 9 years ago by Peter

Status: newassigned

There are four classes: Fisher, PearsonCorrelation?, ROC, and tTest.

comment:4 Changed 8 years ago by Peter

(In [3004]) refs #689. Deprecate Fisher::one_sided_p; implement Fisher::left_p and right_p.

comment:5 Changed 8 years ago by Peter

(In [3005]) refs #689. Deprecate PearsonCorrelation::p_value_one_sided. Replace it with p_right and its friends p_left and p_value.

comment:6 Changed 8 years ago by Peter

(In [3006]) deprecate ROC::p_value, first versions of p_left and p_right (refs #689), but code is terribly duplicated which is better to fix after ticket:754 (refs #754).

comment:7 Changed 8 years ago by Peter

(In [3007]) actually deprecate ROC::p_value_one_sided(). refs #689

comment:8 in reply to:  6 Changed 8 years ago by Peter

Replying to peter:

(In [3006]) deprecate ROC::p_value, first versions of p_left and p_right (refs #689), but code is terribly duplicated which is better to fix after ticket:754 (refs #754).

Worst code duplication was removed in [3023].

comment:9 Changed 8 years ago by Peter

Resolution: fixed
Status: assignedclosed

(In [3025]) implement tTest::p_right(). closes #689

Note: See TracTickets for help on using tickets.