Opened 8 years ago
Closed 8 years ago
#841 closed request (fixed)
Fisher's exact two-sided p-value
| Reported by: | Peter | Owned by: | Peter |
|---|---|---|---|
| Priority: | major | Milestone: | yat 0.14 |
| Component: | statistics | Version: | 0.12.2 |
| Keywords: | Cc: |
Description
The code in Fisher::p_value_exact(void) is obscure and hard to read. How is the value of k picked?
Fiurthermore, as discussed in #461, there are a few different ways to calculate it, and it seems we/I picked the wrong one back then because alternative 3 seems to be the most popular method (http://www.biostathandbook.com/fishers.html).
I think it's OK to just change implementation with a note in NEWS, or should it be an option to use this implementation?
Change History (2)
comment:1 Changed 8 years ago by
| Status: | new → assigned |
|---|
comment:2 Changed 8 years ago by
| Resolution: | → fixed |
|---|---|
| Status: | assigned → closed |
Note: See
TracTickets for help on using
tickets.
(In [3441]) closes #841