Opened 7 years ago
Closed 7 years ago
#874 closed request (fixed)
qQuantileNormalizer with unweighted source and weighted destination
Reported by: | Peter | Owned by: | Peter |
---|---|---|---|
Priority: | minor | Milestone: | yat 0.15 |
Component: | normalizer | Version: | 0.13 |
Keywords: | Cc: |
Description
The qQuantileNormalizer::operator has four cases:
- unweighted source and unweighted destination
- unweighted source and weighted destination
- weighted source and unweighted destination
- weighted source and weighted destination
Currently if either of the ranges is weighted, i.e., case 2-4, the weighted version of normalize
is called. The question is: is this really needed for case 2?
Only time destination weights are used is when they are copied from source via function copy_weight_if_weighted
. If we include a call to that function also in the unweighted version of normalize
(which is faster), we could let that function handle case 2 as well. When the destination is unweighted, copy_weight_if_weighted
is a no-op, so the change will not effect the speed of case 1.
Change History (2)
comment:1 Changed 7 years ago by
Status: | new → assigned |
---|
comment:2 Changed 7 years ago by
Resolution: | → fixed |
---|---|
Status: | assigned → closed |
(In [3572]) fixes #874