Opened 4 years ago

Closed 4 years ago

#940 closed request (fixed)

add failure check in Fasta::fetch

Reported by: Peter Owned by: Peter
Priority: trivial Milestone: yat 0.18
Component: omic Version: trunk
Keywords: Cc:

Description

Currently Fasta::fetch does not check if underlying htslib function failed, but the ::fetch is a private function and in both places the function is called error checks are done. Some of this code is repeated, so it seems better to move into ::fetch. There is also a comment about throwing different exception class depending on type of error (code by -1 or -2).

Change History (2)

comment:1 Changed 4 years ago by Peter

Milestone: yat 0.x+ → yat 0.18
Status: new → accepted

comment:2 Changed 4 years ago by Peter

Resolution: → fixed
Status: accepted → closed

In 3887:

detect error from faidx_fetch_seq in ::fetch rather thasn in function calling ::fetch. closes #940

Note: See TracTickets for help on using tickets.