Opened 2 years ago

Closed 2 years ago

#951 closed defect (wontfix)

PCA(Matrix&&) and SVD(Matrix&&) not implemented

Reported by: Peter Owned by: Jari Häkkinen
Priority: major Milestone:
Component: utility Version: 0.17.1
Keywords: Cc:

Description

PCA(Matrix&&) and SVD(Matrix&&) are not implemented because they are guarded by macro YAT_HAVE_RVALE, which is supposed to be YAT_HAVE_RVALUE.

User can workaround the bug bu defining YAT_HAVE_RVALE when building yat.

Change History (1)

comment:1 Changed 2 years ago by Peter

Milestone: yat 0.17.2
Resolution: wontfix
Status: newclosed

The header files have the same issue, which means it's less of an issue. Practically it means constructors are never available (unless user #defines these misspelled macros) nor in the headers or implemented in the library. Since the library works as it is now and code will just use the constructors taking Matrix& I'm reluctant to fix the typo in a stable branch and practically add a interface.

This won't be an issue in yat 0.18 when these macros are gone.

Note: See TracTickets for help on using tickets.